All these years since the introduction of the laptops, i feel like it will never replace the desktops. It is just the same way someone was arguing that tablets will replace laptops which is something that will never happen. It all depends on the functionality. All these devices have their own away of being practical and that is when you use the.
In my opinion, it depends on your needs whether you need a desktop computer or a laptop. If you do heavy gaming, I would recommend you to go with a desktop computer simply for the reason that desktops generally are better in terms of performance when you compare similarly priced laptops and desktops. But if you want to browse the internet and do regular stuff, I would recommend you to go with a laptop, simply due to its portability.
I'd prefer desktops, they're more flexible when it comes to upgrades, has a longer lifespan and much powerful than laptops, and also cheaper. But it depends more on your needs, it always does. The thing is, laptops are portable, they're made for travel and as a result, they have to compress it, the more powerful the laptop the heavier it is. As for desktops, if you're work requires tons and tons of computing power then desktops are definitely for you.